-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove some import abstracts/variables #11276
Merged
preschian
merged 4 commits into
main
from
refactor--remove-some-import-abstracts/variables
Dec 26, 2024
Merged
refactor: remove some import abstracts/variables #11276
preschian
merged 4 commits into
main
from
refactor--remove-some-import-abstracts/variables
Dec 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents - Removed unused SCSS imports and variables from multiple components. - Replaced theme-based styles with Tailwind CSS utility classes for consistency. - Enhanced styling for various elements, including buttons, banners, and popovers, to improve visual coherence. - Introduced a new utility class for text shadows to enhance text visibility. These changes aim to simplify the styling approach and improve maintainability.
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying koda-art-prod with
|
Latest commit: |
7b9f9fe
|
Status: | ✅ Deploy successful! |
Preview URL: | https://20bb9ee5.kodaart-production.pages.dev |
Branch Preview URL: | https://refactor--remove-some-import.kodaart-production.pages.dev |
- Enhanced styling in multiple components by replacing SCSS with Tailwind CSS utility classes for improved consistency and maintainability. - Removed unused SCSS styles and variables, streamlining the codebase. - Adjusted layout and positioning for better responsiveness and visual coherence across components. - Improved accessibility and hover states for buttons and interactive elements. These changes aim to simplify the styling approach and enhance the overall user experience.
…remove-some-import-abstracts/variables
hassnian
approved these changes
Dec 22, 2024
vikiival
approved these changes
Dec 22, 2024
|
cc @preschian @Jarsen136 can you please check if nothing was broken? |
Jarsen136
approved these changes
Dec 22, 2024
This was referenced Dec 26, 2024
Merged
This was referenced Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
@import '@/assets/styles/abstracts/variables';
in some files. part of CSS Refactoring step 1 #8071