Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove some import abstracts/variables #11276

Merged
merged 4 commits into from
Dec 26, 2024

Conversation

preschian
Copy link
Member

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

…ents

- Removed unused SCSS imports and variables from multiple components.
- Replaced theme-based styles with Tailwind CSS utility classes for consistency.
- Enhanced styling for various elements, including buttons, banners, and popovers, to improve visual coherence.
- Introduced a new utility class for text shadows to enhance text visibility.

These changes aim to simplify the styling approach and improve maintainability.
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 7b9f9fe
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/676808e17473580008e852a3
😎 Deploy Preview https://deploy-preview-11276--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Dec 19, 2024

Deploying koda-art-prod with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7b9f9fe
Status: ✅  Deploy successful!
Preview URL: https://20bb9ee5.kodaart-production.pages.dev
Branch Preview URL: https://refactor--remove-some-import.kodaart-production.pages.dev

View logs

@preschian preschian marked this pull request as ready for review December 20, 2024 09:12
@preschian preschian requested a review from a team as a code owner December 20, 2024 09:12
@preschian preschian requested review from vikiival and hassnian and removed request for a team December 20, 2024 09:12
- Enhanced styling in multiple components by replacing SCSS with Tailwind CSS utility classes for improved consistency and maintainability.
- Removed unused SCSS styles and variables, streamlining the codebase.
- Adjusted layout and positioning for better responsiveness and visual coherence across components.
- Improved accessibility and hover states for buttons and interactive elements.

These changes aim to simplify the styling approach and enhance the overall user experience.
Copy link

@vikiival
Copy link
Member

cc @preschian @Jarsen136 can you please check if nothing was broken?

@preschian preschian added this pull request to the merge queue Dec 26, 2024
Merged via the queue into main with commit f97c718 Dec 26, 2024
27 checks passed
@preschian preschian deleted the refactor--remove-some-import-abstracts/variables branch December 26, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants