Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: swap successful redirect #11247

Merged
merged 3 commits into from
Dec 16, 2024
Merged

fix: swap successful redirect #11247

merged 3 commits into from
Dec 16, 2024

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    1734033821711

@Jarsen136 Jarsen136 requested a review from a team as a code owner December 12, 2024 20:06
@Jarsen136 Jarsen136 requested review from preschian and hassnian and removed request for a team December 12, 2024 20:06
@netlify Netlify
Copy link

netlify bot commented Dec 12, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2bfc20f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/675ed74c18483f00087c0ea0
😎 Deploy Preview https://deploy-preview-11247--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian
Copy link
Contributor

hassnian commented Dec 13, 2024 •
edited
Loading

notification text got a little long, let's use this

it's already implemented in MakeOfferModal.vue -> showIndexerDelayMessage

or implement that prop in a normal transaction notification

@Jarsen136
Copy link
Contributor Author

notification text got a little long, let's use this

it's already implemented in `MakeOfferModal.vue` -> `showIndexerDelayMessage`

or implement that prop in a normal transaction notification

updated

image

hassnian
hassnian reviewed Dec 15, 2024
View reviewed changes
Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@hassnian hassnian added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Dec 16, 2024
@vikiival vikiival added this pull request to the merge queue Dec 16, 2024
Merged via the queue into kodadot:main with commit 8f9b95d Dec 16, 2024
24 checks passed
This was referenced Dec 26, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@hassnian hassnian hassnian approved these changes

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swap Landing follow up
4 participants
@Jarsen136 @hassnian @preschian @vikiival