Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Collection Edit: Support Name Update and Description Update #11199

Merged
merged 5 commits into from
Dec 4, 2024
Merged

feat: Collection Edit: Support Name Update and Description Update #11199

merged 5 commits into from
Dec 4, 2024

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs QA check

  • @kodadot/qa-guild please review

Context

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
image image

@Jarsen136 Jarsen136 requested a review from a team as a code owner November 29, 2024 12:55
@Jarsen136 Jarsen136 requested review from vikiival and hassnian and removed request for a team November 29, 2024 12:55
@netlify Netlify
Copy link

netlify bot commented Nov 29, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c27e4c9
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/67502a2ee945bb000804b106
😎 Deploy Preview https://deploy-preview-11199--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Dec 3, 2024
@vikiival vikiival added this pull request to the merge queue Dec 4, 2024
Merged via the queue into kodadot:main with commit 7193ac9 Dec 4, 2024
19 of 21 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

This was referenced Dec 10, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@hassnian hassnian hassnian approved these changes

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collection Edit: Support Description Update Collection Edit: Support Name Update
3 participants
@Jarsen136 @vikiival @hassnian