Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ParaSpell to v7.2.0 #11180

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Update ParaSpell to v7.2.0 #11180

merged 1 commit into from
Nov 22, 2024

Conversation

dudo50
Copy link
Contributor

@dudo50 dudo50 commented Nov 17, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • Closes #<issue_number>
  • Requires deployment <worker/stick/speck>

The following PR features the latest version of ParaSpell XCM SDK.
We introduced many new features since v6 such as:

  • Multilocation asset selection
  • Advanced symbol selection
  • Support for new nodes and new complex scenarios
  • Support for PAPI version (You do not need to install both packages. Just one package of your choice.)

And many more. Feel free to explore changelogs:
https://github.com/paraspell/xcm-tools/releases

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings

  • I've merged recent default branch -- main and I've no conflicts

  • I've tried to respect high code quality standards

  • I've didn't break any original functionality

  • tested and all works on dev version in localhost.

Optional

  • I've tested it at </ahp/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@dudo50 dudo50 requested a review from a team as a code owner November 17, 2024 12:21
@dudo50 dudo50 requested review from preschian and hassnian and removed request for a team November 17, 2024 12:21
Copy link

netlify bot commented Nov 17, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit a5115d5
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6739dfb4859f48000871b72d
😎 Deploy Preview https://deploy-preview-11180--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@paraspell/sdk@7.2.0 Transitive: environment, filesystem, network +4 2.82 MB dudo50

🚮 Removed packages: npm/@paraspell/sdk@6.1.1

View full report↗︎

@vikiival
Copy link
Member

Support for PAPI version (You do not need to install both packages. Just one package of your choice.)

How is it handled on the side of your package?
is it checked on the install ?

@dudo50
Copy link
Contributor Author

dudo50 commented Nov 20, 2024

@vikiival, both PJS and PAPI are an optional peer dependency. They are then imported under different paths:

///PJS
import {Builder} from '@paraspell/sdk'
///PAPI
import {Builder} from '@paraspell/sdk/papi'

Everything is 1:1 otherwise.

With kind regards,
Team ParaSpell✨

@vikiival vikiival merged commit 8821ba3 into kodadot:main Nov 22, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants