Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: code checker more validation #11119

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Oct 19, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Arkain faced some issues doing his drop

  • add: check if p5.min.js file is present, will show
    CleanShot 2024-10-19 at 10 25 03@2x
  • add: check if postMessageKoda is called , will show

CleanShot 2024-10-19 at 10 30 25@2x

@JustLuuuu would you want a separate check ? or is this clear enough? or we can change the copy to include

postMessageKoda() is not called at the end of the draw() function

function draw() {
  background(bg)
  // Once the drawing is done, we can send the image to the parent window
  postMessageKoda()
}

@hassnian hassnian requested a review from a team as a code owner October 19, 2024 05:34
@hassnian hassnian requested review from preschian and vikiival and removed request for a team October 19, 2024 05:34
Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit b955523
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/671344f13cf3cd0009cba6ce
😎 Deploy Preview https://deploy-preview-11119--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@vikiival
Copy link
Member

cc @JustLuuuu

@JustLuuuu
Copy link
Member

I think this should be enough!

@JustLuuuu
Copy link
Member

wfm

@hassnian hassnian added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Oct 23, 2024
@vikiival vikiival added this pull request to the merge queue Oct 25, 2024
Merged via the queue into kodadot:main with commit a47abc7 Oct 25, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants