Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Control return to confirm action #11113

Merged
merged 5 commits into from
Oct 21, 2024
Merged

feat: Control return to confirm action #11113

merged 5 commits into from
Oct 21, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Oct 17, 2024 •
edited
Loading

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

continue #10306

@Jarsen136 let me know if you find anything, this approach seems to fix the issues that had previously and it's simpler imo

Needs Design check

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-10-17 at 12 22 44

@hassnian hassnian requested a review from Jarsen136 October 17, 2024 07:22
@hassnian hassnian requested a review from a team as a code owner October 17, 2024 07:22
@hassnian hassnian requested review from vikiival and removed request for a team October 17, 2024 07:22
@netlify Netlify
Copy link

netlify bot commented Oct 17, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f8b92a7
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/67131433b4175100082c3384
😎 Deploy Preview https://deploy-preview-11113--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian changed the title add: Control return to confirm action feat: Control return to confirm action Oct 17, 2024
Jarsen136
Jarsen136 reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks ok to me

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@vikiival vikiival added this pull request to the merge queue Oct 21, 2024
Merged via the queue into kodadot:main with commit bd83e6e Oct 21, 2024
22 checks passed
This was referenced Oct 23, 2024
Merged
Merged
This was referenced Nov 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Control return to confirm action
3 participants
@hassnian @vikiival @Jarsen136