Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Create NFT empty collection list #11111

Merged
merged 5 commits into from
Oct 16, 2024
Merged

fix: Create NFT empty collection list #11111

merged 5 commits into from
Oct 16, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Oct 16, 2024 •
edited
Loading

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • fix: auth address not changing on prefix change
  • ref(useCollectionForMint): cleaner logic with useQuery from tanstack
  • ref(ChooseCollectionDropdown.vue): disabled selection while loading and show loading label
  • Closes Create NFT empty collection list #11110

Screenshot 📸

  • My fix has changed something on UI;
CleanShot.2024-10-16.at.12.19.38.mp4

@hassnian hassnian requested a review from a team as a code owner October 16, 2024 07:02
@hassnian hassnian requested review from vikiival and Jarsen136 and removed request for a team October 16, 2024 07:02
@netlify Netlify
Copy link

netlify bot commented Oct 16, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 649f232
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/670f68fd5f4a1f000880010e
😎 Deploy Preview https://deploy-preview-11111--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian marked this pull request as draft October 16, 2024 07:04
@hassnian hassnian marked this pull request as ready for review October 16, 2024 07:13
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@vikiival vikiival added this pull request to the merge queue Oct 16, 2024
Merged via the queue into kodadot:main with commit 07a4eef Oct 16, 2024
22 checks passed
This was referenced Oct 18, 2024
Merged
Merged
Merged
This was referenced Nov 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create NFT empty collection list
3 participants
@hassnian @vikiival @Jarsen136