Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 ImageMedia object-contain #11107

Merged
merged 1 commit into from
Oct 16, 2024
Merged

🔧 ImageMedia object-contain #11107

merged 1 commit into from
Oct 16, 2024

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 15, 2024

Here we go again

Screenshot 2024-10-15 at 13-37-19 OG WUD BURN NFT Collection 🔥🔥🔥🔥 One Stop Shop for Polkadot NFTs

Screenshot 2024-10-15 at 13-37-29 BRONZE #73 - OG WUD BURN NFT One Stop Shop for Polkadot NFTs

@roiLeo roiLeo requested a review from a team as a code owner October 15, 2024 11:39
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team October 15, 2024 11:39
@netlify Netlify
Copy link

netlify bot commented Oct 15, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 140c4b9
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/670e547e6aa4da0008ce6ab4
😎 Deploy Preview https://deploy-preview-11107--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@vikiival
Copy link
Member

Then It will break generative art no?

@roiLeo
Copy link
Contributor Author

roiLeo commented Oct 15, 2024 •
edited
Loading

Then It will break generative art no?

it will add black stripes on non-square item ref. MDN (maybe link #4920)

@vikiival
Copy link
Member

ref. MDN

French MDN hits differently

@vikiival vikiival added this pull request to the merge queue Oct 16, 2024
Merged via the queue into kodadot:main with commit 9309bd4 Oct 16, 2024
22 checks passed
@filippoweb3
Copy link

Thank you guys!

@vikiival
Copy link
Member

vikiival commented Oct 16, 2024 •
edited
Loading

Thank you guys!

Should be available on canary.kodadot.xyz

Beta release should be today - #11109

This was referenced Oct 18, 2024
Merged
Merged
Merged
This was referenced Nov 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NFT rendering scaled to aspect ratio
5 participants
@roiLeo @vikiival @filippoweb3 @preschian @Jarsen136