Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/attributes #11098

Merged
merged 3 commits into from
Oct 12, 2024
Merged

fix/attributes #11098

merged 3 commits into from
Oct 12, 2024

Conversation

vikiival
Copy link
Member

  • 🏷️ correct type for attribute
  • πŸ› attributes should be handled normally

Thank you for your contribution to the Koda - Generative Art Marketplace.

πŸ‘‡ __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

(please remove design and QA checks below if not needed)

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

  • Closes #<issue_number>
  • Requires deployment <worker/stick/speck>

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ahp/collection>
  • I've tested PR on mobile
  • I've written unit tests πŸ§ͺ
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot πŸ“Έ

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@vikiival vikiival requested a review from a team as a code owner October 12, 2024 18:36
Copy link

cloudflare-workers-and-pages bot commented Oct 12, 2024

Deploying koda-art-prod with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: b8da1be
Status:Β βœ…Β  Deploy successful!
Preview URL: https://72ca62d7.kodaart-production.pages.dev
Branch Preview URL: https://fix-attributes.kodaart-production.pages.dev

View logs

@vikiival vikiival requested review from preschian and Jarsen136 and removed request for a team October 12, 2024 18:36
Copy link

netlify bot commented Oct 12, 2024

βœ… Deploy Preview for koda-canary ready!

Name Link
πŸ”¨ Latest commit b8da1be
πŸ” Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/670ac577d10c340008021ca2
😎 Deploy Preview https://deploy-preview-11098--koda-canary.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@vikiival
Copy link
Member Author

https://image-beta.w.kodadot.xyz/ipfs/bafybeibwfedjla6xpjagi55vcorjz3alk4kk5tgzhtzu3isaxqtbgs4wse/2.json

Works

@vikiival vikiival merged commit 53f38bc into main Oct 12, 2024
23 checks passed
@vikiival vikiival deleted the fix/attributes branch October 12, 2024 19:25
@filippoweb3
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants