💅 show date only when it is defined

[vikiival]

Thank you for your contribution to the Koda - Generative Art Marketplace.

PR Type

• Bugfix
• Feature
• Refactoring

Context

I was trying to find out why do we have 'Invalid Date' on collections, as this info is passed from the server I do not see why is it failing.

This PR hides the date when date is undefined

> createdAt = '2024-08-01T11:09:48.000000Z'
'2024-08-01T11:09:48.000000Z'
> new Date(createdAt).toLocaleDateString()
'8/1/2024'
> new Date(undefined).toLocaleDateString()
'Invalid Date'

Screenshot 📸

• My fix has changed something on UI; a screenshot is best to understand changes for others.

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	d63823e
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/67027b1bf6db9a00088c2fbd
😎 Deploy Preview	https://deploy-preview-11085--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[vikiival]

cc @preschian is it possible to 'repurge' cache or why is this happening?

[cloudflare-workers-and-pages]

Deploying koda-art-prod with    Cloudflare Pages

Latest commit:	d63823e
Status:	✅  Deploy successful!
Preview URL:	https://ee350dca.kodaart-production.pages.dev
Branch Preview URL:	https://fix-invalid-date.kodaart-production.pages.dev

View logs

[preschian]

cc @preschian is it possible to 'repurge' cache or why is this happening?

purge from where? created at is from indexer:

nft-gallery/components/collection/utils/useCollectionDetails.ts

Lines 116 to 128 in cf89e8f

	const { data } = useQuery({
	queryKey: ['collection-minimal', isAssetHub, collectionId],
	queryFn: async () =>
	collectionId.value
	? (await useAsyncGraphql({
	query: isAssetHub.value
	? 'collectionByIdMinimalWithRoyalty'
	: 'collectionByIdMinimal',
	variables: variables.value,
	clientId: client.value,
	})).data.value
	: null,
	})

imo, would be better if we get it from oda-worker instead

[vikiival]

Please observe screenshots above

[preschian]

Please observe screenshots above

because it's not blocking request to render the component. please see code snippet above and the props here:

nft-gallery/components/collection/CollectionInfo.vue

Line 148 in d63823e

const createdAt = computed(() => props.collection?.createdAt)

[vikiival]

So why is it invalid date then on prod and valid date on any other?

[preschian]

So why is it invalid date then on prod and valid date on any other?

it was fixed here: #11039

[vikiival]

Thanks