Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/statick without rmrk #11080

Merged
merged 22 commits into from
Oct 21, 2024
Merged

chore/statick without rmrk #11080

merged 22 commits into from
Oct 21, 2024

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Oct 4, 2024

  • rmrk out of libs/static/src/chains.ts
  • rmrk out of libs/static/src/endpoints.ts
  • rmrk out of libs/static/src/indexers.ts
  • rmrk out of libs/static/src/names.ts
  • rmrk out of libs/static/src/services.ts
  • rmrk out of libs/static/src/types.ts
  • 🧑‍💻 show data based on assethubs
  • app: remove rmrk prefix from composables/useBlockTime.ts
  • app: remove rmrk prefix from composables/useTransak.ts
  • app: remove rmrk prefix from composables/useUsdValue.ts
  • app: remove rmrk prefix from stores/identity.ts
  • app: remove rmrk prefix from utils/chain.ts
  • app: remove rmrk prefix from utils/teleport.ts

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

removes rmrk prefix, ksm will be available

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ahp/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@vikiival vikiival requested a review from a team as a code owner October 4, 2024 12:19
@vikiival vikiival requested review from preschian and hassnian and removed request for a team October 4, 2024 12:19
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 4, 2024 •
edited
Loading

Deploying koda-art-prod with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8836d42
Status: ✅  Deploy successful!
Preview URL: https://eda826a5.kodaart-production.pages.dev
Branch Preview URL: https://chore-statick-without-rmrk.kodaart-production.pages.dev

View logs

@netlify Netlify
Copy link

netlify bot commented Oct 4, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 8836d42
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/67167b2e296991000855ece0
😎 Deploy Preview https://deploy-preview-11080--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@socket-security Socket Security
Copy link

socket-security bot commented Oct 4, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@roiLeo
Copy link
Contributor

roiLeo commented Oct 4, 2024

Adios-thumbnail-url-41rbv4

@Jarsen136
Copy link
Contributor

This page was broken. https://deploy-preview-11080--koda-canary.netlify.app/ahk/teleport

@preschian preschian requested a review from Jarsen136 October 7, 2024 14:02
@vikiival
Copy link
Member Author

This page was broken. https://deploy-preview-11080--koda-canary.netlify.app/ahk/teleport

Can I ask you to fix it pls?

@Jarsen136
Copy link
Contributor

This page was broken. https://deploy-preview-11080--koda-canary.netlify.app/ahk/teleport

Can I ask you to fix it pls?

will fix it

@Jarsen136
Copy link
Contributor

This page was broken. https://deploy-preview-11080--koda-canary.netlify.app/ahk/teleport

Can I ask you to fix it pls?

will fix it

Done 22c4b80

teleport Tested
ksm -> ahk : https://assethub-kusama.subscan.io/xcm_message/kusama-c4aff010b59ff14266a4d6ef61523ea3023064a7

ahk -> ksm : https://assethub-kusama.subscan.io/xcm_message/kusama-d4e66672afa0cbdf6182da0cc3cead690ddb7b77

vikiival
vikiival commented Oct 16, 2024
View reviewed changes
Copy link
Member Author

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kodadot/internal-dev can you pls review ?

Jarsen136
Jarsen136 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

preschian
preschian reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@preschian preschian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transfer page on canary:
Screenshot 2024-10-21 at 18 25 51

in this PR doesnt show the message. TypeError: Cannot read properties of undefined (reading 'ss58Format')

detected on e2e test

@vikiival
Copy link
Member Author

cc @Jarsen136 ❤️

@Jarsen136
Copy link
Contributor

transfer page on canary: Screenshot 2024-10-21 at 18 25 51

in this PR doesnt show the message. TypeError: Cannot read properties of undefined (reading 'ss58Format')

detected on e2e test

✅ Fixed 4909576

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@tanstack/vue-query@5.56.2 environment +2 3.13 MB tannerlinsley
npm/@transak/transak-sdk@1.4.1 None 0 67.7 kB kutsav
npm/@types/jest@27.5.2 None 0 71.4 kB types
npm/@types/lodash@4.17.7 None 0 867 kB types
npm/@types/markdown-it@13.0.9 None +2 48.2 kB types
npm/@types/node@20.16.5 None 0 2.17 MB types
npm/@types/prismjs@1.26.4 None 0 19.2 kB types
npm/@vite-pwa/nuxt@0.10.5 None +2 767 kB userquin

View full report↗︎

@vikiival vikiival added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 32802c4 Oct 21, 2024
22 of 23 checks passed
@vikiival vikiival deleted the chore/statick-without-rmrk branch October 21, 2024 20:32
This was referenced Oct 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@hassnian hassnian hassnian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vikiival @roiLeo @Jarsen136 @preschian @hassnian