Trim trailing zeroes

[uDaiko]

Thank you for your contribution to the Koda - Generative Art Marketplace.
After I stumpled upon this, as discussed in #10230

👇 __ Let's make a quick check before the contribution.

PR Type

• Bugfix
• Feature
• Refactoring

Needs QA check

• @kodadot/qa-guild please review

Context

• Closes duplicated zeros in decimals #10230
• Requires deployment <worker/stick/speck>

Screenshot 📸

• My fix has changed something on UI; a screenshot is best to understand changes for others.

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	33f14b0
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/670fb7edf041720008f3f35d
😎 Deploy Preview	https://deploy-preview-11068--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Jarsen136]

I just rechecked #10230 and found that it happened when you listed some NFT. Could you also fix it there?

[uDaiko]

@Jarsen136 good catch. Aside from MakingOfferSingleItem and with your Input I found ListingCartSingleItemCart and ListingCartItem where that issue appears. Given that all these basically have the same requirement I thought it would be better to just refactor it and put the parse Code into the balance util. Please have a look.

[vikiival]

cc @uDaiko

[uDaiko]

@hassnian I used the function you mentioned, please have a look. It's working however I noticed that leaving the roundBy parameter blank as you suggested results in unreliable rounds from 0.3999 to 0.4. Would probably make sense to just add 4 round to the function calls

[hassnian]

I noticed that leaving the roundBy parameter blank as you suggested results in unreliable rounds from 0.3999 to 0.4.

@uDaiko that's fine, if for some reason you don't need the rounding and you need to show the exact number

you can add a optional logic to roundTo by adding minimumFractionDigits

[uDaiko]

I noticed that leaving the roundBy parameter blank as you suggested results in unreliable rounds from 0.3999 to 0.4.

@uDaiko that's fine, if for some reason you don't need the rounding and you need to show the exact number

you can add a optional logic to roundTo by adding minimumFractionDigits

Well the rounding is already in place in the composable. I was thinking of just passing computed(() => 4)
useAmount(computed(() => props.nft.collection.floor), decimals, chainSymbol, computed(() => 4)) for these 3 instances
alternatively you can have roundTo to have a default of 4 unless stated otherwise but then existing calls of this function would have to be checked and modified so I think it's easier to just pass it where needed here.

[hassnian]

almost there!

[hassnian]

there are a couple of edge cases that need covering , but this is working fine

let's keep it simple, reverted to a prev version 405b0f7

@Jarsen136 code changed a bit pls re-review ty

[vikiival]

Thank u @uDaiko !

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud