Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Button hover on active button #10897

Merged
merged 5 commits into from
Aug 28, 2024
Merged

fix: Button hover on active button #10897

merged 5 commits into from
Aug 28, 2024

Conversation

hassnian
Copy link
Contributor

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Needs Design check

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-08-24 at 12 14 53

@hassnian hassnian requested a review from a team as a code owner August 24, 2024 07:20
@hassnian hassnian requested review from vikiival and Jarsen136 and removed request for a team August 24, 2024 07:20
@netlify Netlify
Copy link

netlify bot commented Aug 24, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d48781b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66cca86194b53900082528f4
😎 Deploy Preview https://deploy-preview-10897--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vikiival
vikiival approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exez said ok

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@hassnian hassnian added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Aug 27, 2024
@hassnian hassnian added this pull request to the merge queue Aug 28, 2024
Merged via the queue into kodadot:main with commit 63bf7e9 Aug 28, 2024
20 of 22 checks passed
@hassnian hassnian deleted the issue-10896 branch August 28, 2024 10:23
This was referenced Sep 9, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees

@exezbcz exezbcz

Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button hover on active button
4 participants
@hassnian @vikiival @Jarsen136 @exezbcz