Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ETH rounding #10857

Merged
merged 4 commits into from
Aug 22, 2024
Merged

feat: ETH rounding #10857

merged 4 commits into from
Aug 22, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Aug 19, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Needs Design check

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit b2e894d
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66c47d8bb2a7f3000863b9b5
😎 Deploy Preview https://deploy-preview-10857--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian
Copy link
Contributor Author

waiting on #10852 (comment)

@hassnian hassnian marked this pull request as ready for review August 20, 2024 04:18
@hassnian hassnian requested a review from a team as a code owner August 20, 2024 04:18
@hassnian hassnian requested review from vikiival and Jarsen136 and removed request for a team August 20, 2024 04:18
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wont this break rounding on ksm/dot?

@hassnian
Copy link
Contributor Author

hassnian commented Aug 20, 2024

Wont this break rounding on ksm/dot?

@vikiival no, it shouldn't let me know if i'm missing something

  1. getting the rounding by prefix is only for evm
    CleanShot 2024-08-20 at 15 24 52@2x

  2. regarding this from roundTo

CleanShot 2024-08-20 at 15 28 35@2x

this will not force the round amount anymore, hiding unnecessary 0, should I change it back?

for context this only runs if a round is provided which for most of the app we don't use, I do need that for evm since the value is smaller and number.toLocaleString() returns 0, removed minimumFractionDigits since it was adding unnecessary 0

ksm exmaple

CleanShot 2024-08-20 at 15 32 25@2x

eth example

CleanShot 2024-08-20 at 15 40 59@2x

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants