-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create offer on AssetHub #10842
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
components/gallery/GalleryItemAction/GalleryItemActionType/GalleryItemOffer.vue
Outdated
Show resolved
Hide resolved
components/gallery/GalleryItemAction/GalleryItemActionType/GalleryItemOffer.vue
Outdated
Show resolved
Hide resolved
i guess the frontend work will be done later? |
so from what i see is missing:
can be done in the other issues |
I would implement them on #10843 For now, the offer duration is set to a fixed 7 days. |
cc @preschian |
components/gallery/GalleryItemAction/GalleryItemActionType/GalleryItemOffer.vue
Outdated
Show resolved
Hide resolved
@Jarsen136 some changes are not updated, otherwise we are almost there :D |
All should be updated now. Could you review it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only 1 missing #10842 (comment)
Co-authored-by: Hassnian <44554284+hassnian@users.noreply.github.com>
@Jarsen136 reviewdog it's failing |
fixed |
|
review request cc @preschian |
Can confirm that:
Thanks @kodadot/internal-dev for Reviews let's continue ^-^ |
Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs Design check
Needs QA check
Context
This PR only contains the basic functionality of creating offer on ahp/ahk. There is still some missing from the UI perspective.
I will create more separate issue base on #10807
Did your issue had any of the "$" label on it?
Screenshot 📸
ahp: https://assethub-polkadot.subscan.io/extrinsic/0x27a32bce6bfa4b91e29523e89bf736bb9b7e7c59eb157851c7ef47ee4f4f8549
ahk: https://assethub-kusama.subscan.io/extrinsic/0x5f8f5b599d088141b570095014fdad3181def781d47a2fe0bc0d10d4fe7e4ebc