-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make sure that EVM connectors work properly #10762
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@vikiival @exezbcz can you test and let me know ? now it should allow you sign with any evm wallet* *I have found another case that is not working (currently investigating that), connecting directly with coinbase works , but if you connect with any evm wallet and disconnect and try to connect with coinbase that's not working for me. |
@hassnian nice, managed to sign a drop mint, good job |
I was able to reproduce this one |
…into issue-10747
took some time to debug, the issue was that we were clearing the entire localstorage when logging out, and coinbase wallet was using that to store data should work now , tried with multiple wallets installed and all flows work. @vikiival @JustLuuuu @kodadot/internal-dev need help testing, let me know if anyone is experiencing any other issue. pls connect with a wallet try minting (the connected wallet should appear) , disconnect that wallet and repeat the same process with another wallet. thanks |
You have some conflicts |
@preschian pls open new issues |
|
done
opened two new issues |
Pls @kodadot/internal-dev make review |
thank you |
PR Type
Context
Did your issue had any of the "$" label on it?
Screenshot 📸