Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Confusing linking on Base #10756

Merged
merged 10 commits into from
Aug 12, 2024
Merged

fix: Confusing linking on Base #10756

merged 10 commits into from
Aug 12, 2024

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Aug 5, 2024 •
edited
Loading

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@Jarsen136 Jarsen136 requested a review from a team as a code owner August 5, 2024 18:46
@Jarsen136 Jarsen136 requested review from preschian and vikiival and removed request for a team August 5, 2024 18:46
@netlify Netlify
Copy link

netlify bot commented Aug 5, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 16084ff
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66b378a889675800079134d4
😎 Deploy Preview https://deploy-preview-10756--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jarsen136 Jarsen136 mentioned this pull request Aug 5, 2024
Closed
preschian
preschian reviewed Aug 7, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Jarsen136 Jarsen136 requested a review from preschian August 7, 2024 13:43
@vikiival vikiival merged commit 5ccfe23 into kodadot:main Aug 12, 2024
21 of 22 checks passed
This was referenced Aug 13, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@vikiival vikiival Awaiting requested review from vikiival vikiival is a code owner automatically assigned from kodadot/code-review-guild

Assignees

@JustLuuuu JustLuuuu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auto-import useRouter is not reactive after initially being set Confusing linking on Base
4 participants
@Jarsen136 @preschian @vikiival @JustLuuuu