fix: display all available chains & check wallet VM when buying / minting nft #10720

Jarsen136 · 2024-08-01T20:49:55Z

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

Bugfix

Needs QA check

@kodadot/qa-guild please review

Context

Display all available chains no matter what kind of wallet(SUB/EVM) you are connected to.

Did your issue had any of the "$" label on it?

My DOT address: Payout

Screenshot 📸

My fix has changed something on UI; a screenshot is best to understand changes for others.

netlify · 2024-08-01T20:50:10Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`82c92a0`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/66c6ef2370e1c50007e591ed
😎 Deploy Preview	https://deploy-preview-10720--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hassnian · 2024-08-02T04:23:21Z

changing this allows you to buy (for example) an ahp nft with a evm wallet connected

let's add this back after #10670 once multi-accounts is implemented

also @vikiival mentioned something about changing that switch to change EVMs and not chains

hassnian · 2024-08-12T09:42:55Z

@jarsen can you include #10796 in this pr ? likely after #10772.

when the user clicks on the network with the wallet connected, display reconnect popup

identify edge cases when the user can cancel the connection and somehow dodge the modal

that should fix

changing this allows you to buy (for example) an ahp nft with a evm wallet connected

exezbcz · 2024-08-12T09:57:44Z

I mean, it does switch chains, but adds even more friction to minting a drop

this is me minting a base drop with a polkadot wallet connected

there has to be a reconnect either when switching the chain or when clicking mint

Jarsen136 · 2024-08-12T10:39:22Z

@jarsen can you include #10796 in this pr ? likely after #10772.

when the user clicks on the network with the wallet connected, display reconnect popup

identify edge cases when the user can cancel the connection and somehow dodge the modal

I've thought the same as you. We could show all available chains on the selector. Whenever the users do something on-chain operation(buy/mint), we will check if the current chain matches the wallet. If not, it will show the reconnect wallet popup modal.

It would be the easiest way to handle multiple chains. cc @exezbcz

exezbcz · 2024-08-12T10:40:46Z

@Jarsen136 yeah this way you are only delaying the reconnect modal to the last possible moment, i am for this. Right now there was the reconnect only when clicking the drop card

we can change it later if we realize it is not optimal

for now it will be quite aligned with the multi account thesis

…ssue-10708

vikiival · 2024-08-14T11:07:28Z

cc @hassnian

hassnian · 2024-08-14T12:35:17Z

@exezbcz s-works? anything that is missing?

.

hassnian · 2024-08-15T06:10:31Z

composables/useTransaction.ts

-          (params as ExecuteSubstrateTransactionParams).cb,
-          arg,
-          {
+    doAfterCheckCurrentChainVM(() => {


I get this approach but I'm not too sold on adding doAfterCheckCurrentChainVM inside useTransaction
I'd rather show the modal before the action has started.

maybe because this is simplest solution atm?

see

just a visual examaple of a case where this would run after action has started

@preschian wdyt

I'd rather show the modal before the action has started.

maybe because this is simplest solution atm?

Yes, it's the simplest solution, then we don't need to add this check everywhere.

although I have added checks for most cases such as mint/drop/buy, I leave it here to make sure it is impossible to do on-chain operations with an incorrect wallet.

hassnian

spent some time doing qa

code has changed quite a bit, re-requesting @preschian review

@exezbcz need your input

now that we have all chains, what should we do here, allow only the current vm wallet or both, same for the drop page

we should remove that modal here and allow reconnect inside the drop (already working)

create collection and create nft missing the switch modal
wallet connect modal selects the a defualt vm chain after the wallet is connected, pls remove that , otherwise you can do stuff like this

minting a collection on base

CleanShot.2024-08-15.at.10.44.51.mp4

unrelated this pr (new issue pls) , drop page can't change prefix , it's kinda weird allowing to change the chain and changing it back

CleanShot.2024-08-15.at.10.49.31.mp4

Jarsen136 · 2024-08-15T08:45:36Z

spent some time doing qa

Thanks for taking the time to test it!

now that we have all chains, what should we do here, allow only the current vm wallet or both, same for the drop page

we should remove that modal here and allow reconnect inside the drop (already working)

-> 1, 2
I will wait for @exezbcz response as this is the existing interaction process.

create collection and create nft missing the switch modal

wallet connect modal selects the a defualt vm chain after the wallet is connected, pls remove that , otherwise you can do stuff like this

minting a collection on base

-> 3, 4

I have just fixed it.

unrelated this pr (new issue pls) , drop page can't change prefix , it's kinda weird allowing to change the chain and changing it back

CleanShot.2024-08-15.at.10.49.31.mp4

will create another issue.

preschian · 2024-08-16T10:22:22Z

spent some time doing qa

code has changed quite a bit, re-requesting @preschian review

thanks

vikiival · 2024-08-16T10:56:09Z

cc @exezbcz

exezbcz · 2024-08-17T09:17:00Z

I've thought the same as you. We could show all available chains on the selector. Whenever the users do something on-chain operation(buy/mint), we will check if the current chain matches the wallet. If not, it will show the reconnect wallet popup modal.

yeah this sounds like it will be the easiest

for a second i though making it dynamic based on where the user currently is but that would bring even more complexity

so to answer:

now that we have all chains, what should we do here, allow only the current vm wallet or both, same for the drop page

lets show both, with the "current VM tab" preselected

being on base and hitting connect (randomly on any page) it will show the evm tab selected
being on polkadot eco, it will have ahp tab selected

3. we should remove that modal here and allow reconnect inside the drop (already working)

yeah lets delay the reconnect till the last possible moment

thanks for testing @hassnian and thank you for the implementation @Jarsen136 !

Jarsen136 · 2024-08-18T10:02:55Z

so to answer:

now that we have all chains, what should we do here, allow only the current vm wallet or both, same for the drop page

lets show both, with the "current VM tab" preselected

being on base and hitting connect (randomly on any page) it will show the evm tab selected

being on polkadot eco, it will have ahp tab selected

we should remove that modal here and allow reconnect inside the drop (already working)

yeah lets delay the reconnect till the last possible moment

✅ Updated

components/common/ConnectWallet/WalletTabs.vue

exezbcz · 2024-08-21T10:33:35Z

what is left here?

can you review please @preschian ?

sonarqubecloud · 2024-08-22T07:57:04Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

fix display all avaliable chains

e7c7544

Jarsen136 requested a review from a team as a code owner August 1, 2024 20:49

Jarsen136 requested review from preschian and hassnian and removed request for a team August 1, 2024 20:49

Jarsen136 changed the title ~~fix display all available chains~~ fix: display all available chains Aug 1, 2024

preschian approved these changes Aug 2, 2024

View reviewed changes

Merge branch 'main' into issue-10708

3232ea6

Jarsen136 marked this pull request as draft August 12, 2024 10:44

Jarsen136 added 2 commits August 12, 2024 13:26

Merge branch 'main' into issue-10708

3153b72

feat: check chain match

dd7112a

Jarsen136 marked this pull request as ready for review August 12, 2024 12:42

Jarsen136 changed the title ~~fix: display all available chains~~ fix: display all available chains & check wallet VM when buying / minting nft Aug 12, 2024

Jarsen136 added 2 commits August 12, 2024 14:57

Merge branch 'issue-10708' of github.com:Jarsen136/nft-gallery into i…

9b6aef0

…ssue-10708

Merge branch 'main' into issue-10708

919db4d

hassnian previously approved these changes Aug 14, 2024

View reviewed changes

hassnian assigned exezbcz Aug 14, 2024

hassnian reviewed Aug 15, 2024

View reviewed changes

hassnian requested changes Aug 15, 2024

View reviewed changes

hassnian requested a review from preschian August 15, 2024 06:15

fix: mint on base

63d5b17

Jarsen136 mentioned this pull request Aug 15, 2024

Drop page can't change prefix #10817

Closed

Merge branch 'main' into issue-10708

7f8dd71

vikiival requested a review from hassnian August 16, 2024 10:55

Jarsen136 added 2 commits August 18, 2024 11:34

Merge branch 'main' into issue-10708

0d4ad0a

fix: drops connect wallet

24a7d9e

exezbcz mentioned this pull request Aug 18, 2024

wallet switching from evm wallet to polkadot drop #10853

Closed

hassnian approved these changes Aug 20, 2024

View reviewed changes

components/common/ConnectWallet/WalletTabs.vue Outdated Show resolved Hide resolved

Jarsen136 added 2 commits August 20, 2024 16:38

chore: computed

79cd2bb

Merge branch 'main' into issue-10708

f51f31e

exezbcz added the S-visual-ok-✅ label Aug 21, 2024

preschian approved these changes Aug 22, 2024

View reviewed changes

Merge branch 'main' into issue-10708

82c92a0

vikiival merged commit c83aa5d into kodadot:main Aug 22, 2024
20 of 21 checks passed

vikiival mentioned this pull request Aug 22, 2024

(beta): 75% of August 2024 Unicorn 🦄 #10886

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: display all available chains & check wallet VM when buying / minting nft #10720

fix: display all available chains & check wallet VM when buying / minting nft #10720

Jarsen136 commented Aug 1, 2024 •

edited

Loading

netlify bot commented Aug 1, 2024 •

edited

Loading

hassnian commented Aug 2, 2024 •

edited

Loading

hassnian commented Aug 12, 2024 •

edited

Loading

exezbcz commented Aug 12, 2024

Jarsen136 commented Aug 12, 2024

exezbcz commented Aug 12, 2024 •

edited

Loading

vikiival commented Aug 14, 2024

hassnian commented Aug 14, 2024 •

edited

Loading

hassnian Aug 15, 2024 •

edited

Loading

Jarsen136 Aug 15, 2024

hassnian left a comment •

edited

Loading

Jarsen136 commented Aug 15, 2024 •

edited

Loading

preschian commented Aug 16, 2024

vikiival commented Aug 16, 2024

exezbcz commented Aug 17, 2024

Jarsen136 commented Aug 18, 2024

so to answer:

exezbcz commented Aug 21, 2024 •

edited

Loading

sonarqubecloud bot commented Aug 22, 2024

fix: display all available chains & check wallet VM when buying / minting nft #10720

fix: display all available chains & check wallet VM when buying / minting nft #10720

Conversation

Jarsen136 commented Aug 1, 2024 • edited Loading

PR Type

Needs QA check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

netlify bot commented Aug 1, 2024 • edited Loading

✅ Deploy Preview for koda-canary ready!

hassnian commented Aug 2, 2024 • edited Loading

hassnian commented Aug 12, 2024 • edited Loading

exezbcz commented Aug 12, 2024

Jarsen136 commented Aug 12, 2024

exezbcz commented Aug 12, 2024 • edited Loading

vikiival commented Aug 14, 2024

hassnian commented Aug 14, 2024 • edited Loading

hassnian Aug 15, 2024 • edited Loading

Choose a reason for hiding this comment

Jarsen136 Aug 15, 2024

Choose a reason for hiding this comment

hassnian left a comment • edited Loading

Choose a reason for hiding this comment

Jarsen136 commented Aug 15, 2024 • edited Loading

preschian commented Aug 16, 2024

vikiival commented Aug 16, 2024

exezbcz commented Aug 17, 2024

so to answer:

Jarsen136 commented Aug 18, 2024

so to answer:

exezbcz commented Aug 21, 2024 • edited Loading

sonarqubecloud bot commented Aug 22, 2024

Quality Gate passed

Jarsen136 commented Aug 1, 2024 •

edited

Loading

netlify bot commented Aug 1, 2024 •

edited

Loading

hassnian commented Aug 2, 2024 •

edited

Loading

hassnian commented Aug 12, 2024 •

edited

Loading

exezbcz commented Aug 12, 2024 •

edited

Loading

hassnian commented Aug 14, 2024 •

edited

Loading

hassnian Aug 15, 2024 •

edited

Loading

hassnian left a comment •

edited

Loading

Jarsen136 commented Aug 15, 2024 •

edited

Loading

exezbcz commented Aug 21, 2024 •

edited

Loading