Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use objectMapperForSerialization for kotlin type classes #996

Merged
merged 3 commits into from
Sep 5, 2022

Conversation

jay3047
Copy link
Contributor

@jay3047 jay3047 commented Sep 4, 2022


Description

Related to #995


Changes were made to:

  • Codegen library - Java
  • Codegen library - Kotlin
  • Codegen library - Scala
  • Maven plugin
  • Gradle plugin
  • SBT plugin

@jxnu-liguobin jxnu-liguobin self-requested a review September 5, 2022 06:30
@jay3047 jay3047 changed the base branch from master to develop September 5, 2022 07:07
@jay3047
Copy link
Contributor Author

jay3047 commented Sep 5, 2022

Not sure why sonar is failing , @jxnu-liguobin can you please help.

I think forked repo by default doesn't copy develop branch and we tend to create working branch from master which doesn't have develop under .git/refs/head

@jxnu-liguobin
Copy link
Collaborator

sonar

Usually we do not need to care about soar.

@jay3047
Copy link
Contributor Author

jay3047 commented Sep 5, 2022

sonar

Usually we do not need to care about soar.

Okay , in that case can you please review and merge if changes looks ok.

@jay3047
Copy link
Contributor Author

jay3047 commented Sep 5, 2022

@kobylynskyi Can you please review and merge

@jxnu-liguobin
Copy link
Collaborator

@kobylynskyi Can you please review and merge

He's probably still sleeping 😄 .

@kobylynskyi kobylynskyi merged commit 6dc3cf2 into kobylynskyi:develop Sep 5, 2022
@kobylynskyi kobylynskyi mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants