Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterized field getters in type interface are missing parameters #859 #913

Merged
merged 1 commit into from
Jan 16, 2022

Conversation

kobylynskyi
Copy link
Owner

Description

Related to #859


Changes were made to:

  • Codegen library - Java
  • Codegen library - Kotlin
  • Codegen library - Scala

@kobylynskyi kobylynskyi added this to the 5.4.0 milestone Dec 3, 2021
@kobylynskyi
Copy link
Owner Author

Hi @jxnu-liguobin could you please have a look if same changes should be done in scala/kotlin .ftl files? Thank you!

@kobylynskyi kobylynskyi force-pushed the parameterized-fields-in-type-interface-859 branch 2 times, most recently from 93d0813 to 78eb8d2 Compare December 3, 2021 02:19
@kobylynskyi kobylynskyi force-pushed the parameterized-fields-in-type-interface-859 branch from 78eb8d2 to 8d2ffe4 Compare December 3, 2021 02:19
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jxnu-liguobin
Copy link
Collaborator

Hi @jxnu-liguobin could you please have a look if same changes should be done in scala/kotlin .ftl files? Thank you!

Yes, it need do some work, but since kotlin and scala have treated the type interface as a field, this is a big change to scala and kotlin and must be changed to method

Now

trait ProfileOwner {

    val anyPinnableItems: Boolean

    val email: String
}

Chage to

trait ProfileOwner {

    def anyPinnableItems(a: Int): Boolean

    def email(a: Int): String
}

So, we can create a new issue and follow the problem until there is enough value to do. (using method is not friendly in most cases)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants