Add @JvmStatic annotation to Kotlin builders #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrooks
commented
Aug 13, 2021
| @@ -51,4 +52,4 @@ Please follow the steps below in order to make the changes: | |||
| mvn clean install | |||
| ``` | |||
|
|
|||
| 10. Make sure that `example` projects are compiling and running. | |||
| 11. Make sure that `example` projects are compiling and running. | |||
There was a problem hiding this comment.
How do you do this?
There was a problem hiding this comment.
install library and plugin and then compile example
jxnu-liguobin
approved these changes
Aug 16, 2021
|
A Scala test is failing in the sonar build and locally for me, which doesn't make sense because nothing I changed should affect Scala code. |
kobylynskyi
approved these changes
Aug 27, 2021
|
When can this get merged? |
Merged
kobylynskyi
pushed a commit
that referenced
this pull request
Sep 5, 2021
Co-authored-by: Kyle <kbrooks@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #767
Adds @JvmStatic to the Kotlin builders so that they can be "backwards-compatible" with Java generated code.
CONTRIBUTING.md changed to mention Java 8 due to issue introduced in #741
Changes were made to: