Use Java Double type for GraphQL Float properties #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
============================================
+ Coverage 86.81% 86.83% +0.02%
- Complexity 203 204 +1
============================================
Files 29 29
Lines 508 509 +1
Branches 69 69
============================================
+ Hits 441 442 +1
Misses 44 44
Partials 23 23
Continue to review full report at Codecov.
|
The GraphQL specification says that Float type is double-precision. It is thus effectively equivalent to Java's float. Resolves: #22
|
I rebased so that this only contains the changes related to the Float->Double change. |
kobylynskyi
approved these changes
Mar 17, 2020
|
@joffrey-bion thank you so much for the contribution! |
|
Will release the changes today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #22
GraphQL specification reference:
https://graphql.org/learn/schema/#scalar-types