Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use java.util.List for GQL lists #186

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Use java.util.List for GQL lists #186

merged 1 commit into from
Jun 18, 2020

Conversation

lorenzleutgeb
Copy link
Contributor

@lorenzleutgeb lorenzleutgeb commented Jun 18, 2020 •
edited
Loading

Resolves #185

This is a breaking change, and should hopefully make it into version 2.

@lorenzleutgeb lorenzleutgeb force-pushed the lists branch 3 times, most recently from f01cd9a to b34c877 Compare June 18, 2020 12:53
@kobylynskyi kobylynskyi self-assigned this Jun 18, 2020
@kobylynskyi kobylynskyi self-requested a review June 18, 2020 13:05
@kobylynskyi kobylynskyi added breaking-change Breaking change enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jun 18, 2020
@kobylynskyi kobylynskyi added this to the 2.0.0 milestone Jun 18, 2020
kobylynskyi
kobylynskyi approved these changes Jun 18, 2020
View reviewed changes
Copy link
Owner

@kobylynskyi kobylynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lorenzleutgeb looks great!

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #186 into master will not change coverage.
The diff coverage is 100.0%.

@lorenzleutgeb
Copy link
Contributor Author

Cool. Do you have a timeline for releasing 2?

@kobylynskyi kobylynskyi merged commit 0159315 into kobylynskyi:master Jun 18, 2020
@kobylynskyi
Copy link
Owner

I am planning to do it today (once other open pull requests will be merged)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobylynskyi kobylynskyi kobylynskyi approved these changes

Assignees

@kobylynskyi kobylynskyi

Labels
breaking-change Breaking change bug Something isn't working
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Use java.util.List for lists
2 participants
@lorenzleutgeb @kobylynskyi