Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not skip "...on" in all$ methods for union and interface projections #1376

Conversation

sdaurea
Copy link
Contributor

@sdaurea sdaurea commented Nov 6, 2023


Description

Related to #1375


Changes were made to:

  • Codegen library - Java
  • Codegen library - Kotlin
  • Codegen library - Scala
  • Maven plugin
  • Gradle plugin
  • SBT plugin

@jxnu-liguobin
Copy link
Collaborator

jxnu-liguobin commented Nov 6, 2023

When you open it, does it mean you are in need of it? This is great. Can you test if it really meets the requirements? (Test its results at runtime ) Thank you!

Because I skipped it directly to avoid testing the union.

@alaa-nassef
Copy link

When you open it, does it mean you are in need of it? This is great. Can you test if it really meets the requirements? (Test its results at runtime ) Thank you!

Because I skipped it directly to avoid testing the union.

@jxnu-liguobin to answer your first question, yes, we do need this in the project we're working on and it is currently kind of a blocker for us. As for testing results at runtime, we were planning to do this, but we have to publish our own version first and use it instead, which would need some more time

@kobylynskyi kobylynskyi added this to the 5.9.0 milestone Nov 9, 2023
@kobylynskyi kobylynskyi merged commit 797558d into kobylynskyi:main Nov 9, 2023
@kobylynskyi
Copy link
Owner

@alaa-nassef looks good!. Thanks for the contribution!

@derwild
Copy link

derwild commented Nov 16, 2023

I'm not sure about your release schedule, but can you already say, when the 5.9.0 maven plugin will be released?

@kobylynskyi
Copy link
Owner

@derwild targeting this week.

@derwild
Copy link

derwild commented Nov 16, 2023

@kobylynskyi nice, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"...on" is skipped in all$ methods for union and interface projections
5 participants