Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum default value generation when suffix provided #131 #132

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

kobylynskyi
Copy link
Owner

@kobylynskyi kobylynskyi commented Apr 30, 2020

Fixes #131

@kobylynskyi kobylynskyi added the bug Something isn't working label Apr 30, 2020
@kobylynskyi kobylynskyi self-assigned this Apr 30, 2020
@kobylynskyi
Copy link
Owner Author

@joffrey-bion could you please review this PR?
I know you worked initially on the class DefaultValueMapper.

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #132 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #132      +/-   ##
============================================
+ Coverage     90.83%   90.85%   +0.01%     
  Complexity      413      413              
============================================
  Files            49       49              
  Lines           993      995       +2     
  Branches        131      131              
============================================
+ Hits            902      904       +2     
  Misses           62       62              
  Partials         29       29              
Impacted Files Coverage Δ Complexity Δ
...kyi/graphql/codegen/mapper/DefaultValueMapper.java 87.50% <100.00%> (+0.65%) 21.00 <1.00> (ø)
.../mapper/InputValueDefinitionToParameterMapper.java 92.85% <100.00%> (ø) 4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2099efb...d2168dd. Read the comment docs.

@joffrey-bion
Copy link
Contributor

Great fix, sorry about this prefix/suffix issue!

@kobylynskyi
Copy link
Owner Author

Thanks for the fast review!

@kobylynskyi kobylynskyi merged commit 6f2095a into master Apr 30, 2020
@kobylynskyi kobylynskyi deleted the 131-default-enum-with-suffix branch April 30, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem generating Enum fields and pre/suffix
2 participants