Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codegen when multiple queries having same name #106 #120

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

kobylynskyi
Copy link
Owner

Fixes #106

@kobylynskyi kobylynskyi added the bug Something isn't working label Apr 25, 2020
@kobylynskyi kobylynskyi added this to the 1.7.0 milestone Apr 25, 2020
@kobylynskyi kobylynskyi self-assigned this Apr 25, 2020
@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #120 into master will decrease coverage by 0.03%.
The diff coverage is 91.89%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #120      +/-   ##
============================================
- Coverage     90.86%   90.82%   -0.04%     
- Complexity      401      404       +3     
============================================
  Files            49       49              
  Lines           974      992      +18     
  Branches        127      131       +4     
============================================
+ Hits            885      901      +16     
- Misses           58       59       +1     
- Partials         31       32       +1     
Impacted Files Coverage Δ Complexity Δ
...obylynskyi/graphql/codegen/mapper/MapperUtils.java 86.48% <78.57%> (-3.17%) 20.00 <5.00> (+1.00) ⬇️
...om/kobylynskyi/graphql/codegen/GraphQLCodegen.java 96.92% <100.00%> (+0.02%) 44.00 <0.00> (ø)
...kyi/graphql/codegen/GraphQLCodegenFileCreator.java 75.00% <100.00%> (ø) 5.00 <0.00> (ø)
...apper/FieldDefinitionToRequestDataModelMapper.java 95.23% <100.00%> (+1.48%) 4.00 <3.00> (+1.00)
...per/FieldDefinitionsToResolverDataModelMapper.java 97.87% <100.00%> (+0.19%) 11.00 <2.00> (+1.00)
...ql/codegen/mapper/GraphqlTypeToJavaTypeMapper.java 80.39% <100.00%> (ø) 26.00 <0.00> (ø)
...a/com/kobylynskyi/graphql/codegen/utils/Utils.java 80.00% <100.00%> (ø) 20.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c50d38...1447ef8. Read the comment docs.

@benmccann
Copy link
Contributor

Don't wait for my review. I'm not familiar enough with GraphQL or the codebase yet to be of help

@kobylynskyi
Copy link
Owner Author

@joffrey-bion could you please cross-check this PR? Thank you.

@joffrey-bion
Copy link
Contributor

Looks good to me!

@kobylynskyi kobylynskyi merged commit 33f2d81 into master Apr 27, 2020
@kobylynskyi kobylynskyi deleted the 106-queries-same-name branch April 27, 2020 11:56
@kobylynskyi kobylynskyi removed this from the 1.7.0 milestone Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client-side codegen fails if there are multiple queries with same name
3 participants