Ability to supply a root directory with custom templates: "customTemplatesRoot" #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed/graphql-java-codegen into gradle-custom-templates
kobylynskyi
approved these changes
May 2, 2023
|
@isaac-mercieca looks good! Thanks for the contribution. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The custom template option doesn't work correctly with the Gradle Plugin since the daemon folder is the root instead of the project folder.
The solution included in this pull request includes support for a new configuration
customTemplatesRoot. This will allow the developer to configure the template directory for a project. Since the configuration is available from each of the build plugins the default value for the template's root will be defined by each plugin as the project's root directory.Related to #1158
Changes were made to: