Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made possible to use custom templates #1048

Merged
merged 10 commits into from
Mar 19, 2023
Merged

Conversation

velo
Copy link
Contributor

@velo velo commented Mar 17, 2023


Description

Added the configuration for manually selecting templates. This would allow anyone that needs/wants to modify a output, to do it by themselves.

For instance, I'm would like to use java record with lombok annotations, by using a custom template I can do it.

Related to #146 and potentially many others


Changes were made to:

  • Codegen library - Java
  • Codegen library - Kotlin
  • Codegen library - Scala
  • Maven plugin
  • Gradle plugin
  • SBT plugin

If the change seems reasonable, I will make the gradle plugin and SBT changes

@kobylynskyi kobylynskyi changed the base branch from master to develop March 18, 2023 01:21
@kobylynskyi
Copy link
Owner

kobylynskyi commented Mar 18, 2023

Hey @velo
Thanks for the contribution!
I like this feature.
Please address the comments I put in individual files.
Also here are additional notes:
1 - Please fix the build, for some reason maven codegen fails with NPE: https://github.com/kobylynskyi/graphql-java-codegen/actions/runs/4445081094/jobs/7821033595?pr=1048
2 - If you can append a new record to the end of the configs description table in codegen-options.md.
3 - If you are familiar with Gradle/SBT plugins, please add support to those too.
4 - Please also fix checkstyle warnings

Thank you!

Marvin Froeder and others added 3 commits March 20, 2023 08:55
kobylynskyi
kobylynskyi previously approved these changes Mar 19, 2023
@velo
Copy link
Contributor Author

velo commented Mar 19, 2023

Fixed scalafmt

@kobylynskyi kobylynskyi merged commit 0b212e6 into kobylynskyi:develop Mar 19, 2023
@kobylynskyi kobylynskyi mentioned this pull request Mar 19, 2023
@velo
Copy link
Contributor Author

velo commented Mar 20, 2023

Found a small buh on this, hope I can patch for the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants