Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated dependencies to resolve security vulnerabilities #1046

Merged

Conversation

upendrao
Copy link
Contributor


Description

Related to #1045

Updated following dependencies to resolve security vulnerabilities

  • com.graphql-java:graphql-java
  • com.fasterxml.jackson.core:jackson-databind
    Updated unit tests to be able to parse test schemas with more tokens than the default size(15000)

Changes were made to:

  • Codegen library - Java
  • Codegen library - Kotlin
  • Codegen library - Scala
  • Maven plugin
  • Gradle plugin
  • SBT plugin
  • Dependencies

@kobylynskyi kobylynskyi changed the base branch from master to develop March 16, 2023 11:44
@kobylynskyi
Copy link
Owner

Thanks @upendrao for the contribution!

@kobylynskyi kobylynskyi merged commit 3314b53 into kobylynskyi:develop Mar 16, 2023
@kobylynskyi kobylynskyi added this to the 5.7.0 milestone Mar 16, 2023
@kobylynskyi
Copy link
Owner

@upendrao I've merged your PR and for some reason build in develop branch is now failing: https://github.com/kobylynskyi/graphql-java-codegen/actions/runs/4436709200/jobs/7785474765

@upendrao
Copy link
Contributor Author

@kobylynskyi I'm looking at the failure and shall submit a PR on that.

@upendrao upendrao deleted the 1045-upgrade-graphql-java-to-20 branch March 16, 2023 13:56
@kobylynskyi kobylynskyi mentioned this pull request Mar 19, 2023
@upendrao
Copy link
Contributor Author

Hi @kobylynskyi ! Can I ask you a question here?
I have bunch of graphql schemas from DataHub on top of which I want to write my own custom queries as we run from a GraphQL end point. How can I use this plugin to generate code for custom queries.
For example I tried to add an additional graphql file in the schemas folder for the plugin but could not see any code generated for my custom query. Any leads?

@kobylynskyi
Copy link
Owner

hey @upendrao
few questions:
1 - There's one folder with all the schemas and you created another file with your own queries?
2 - Does your schema file have an extend keyword? If you have queries spread across multiple files you would want to have extend type Query { ... } in every file.
3 - If the answer to questions 1 and 2 is yes, but you still don't see a code generated for your custom schema, then try keeping only your schemas in the folder (deleting all other) and see if classes are generated. You can investigate from there.
Let me know how it goes.

@upendrao
Copy link
Contributor Author

upendrao commented Mar 31, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants