Add resolver argument annotation on parameterized field resolvers #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89488da to
dae938a
Compare
kobylynskyi
requested changes
Mar 14, 2023
src/main/java/com/kobylynskyi/graphql/codegen/mapper/AnnotationsMapper.java
Outdated
Show resolved
Hide resolved
dae938a to
4d21ba1
Compare
Signed-off-by: Clément BUCHART <clement@buchart.dev>
Signed-off-by: Clément BUCHART <clement@buchart.dev>
4d21ba1 to
bebdc29
Compare
kobylynskyi
approved these changes
Mar 18, 2023
Merged
|
It works for me on the server side, but the client code isn't generated correctly (at least in combination with Spring GraphQL). The problem is that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the resolver argument annotation is not applied on parameterized field resolver, which is problematic when using this generator to apply the org.springframework.graphql.data.method.annotation.Argument necessary to work with spring boot graphql integration.
This contains a commit that only adds a assertion file to demonstrate the issue, and another to fix it.
Changes were made to: