Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to combine multiple response projections #985 #1031

Merged
merged 10 commits into from
Feb 22, 2023
Merged

Ability to combine multiple response projections #985 #1031

merged 10 commits into from
Feb 22, 2023

Conversation

kobylynskyi
Copy link
Owner

@kobylynskyi kobylynskyi commented Feb 20, 2023 •
edited
Loading

Description

Related to #985

Changes were made to:

  • Codegen library - Java
  • Codegen library - Kotlin
  • Codegen library - Scala

@kobylynskyi kobylynskyi added this to the 5.5.1 milestone Feb 20, 2023
@kobylynskyi kobylynskyi force-pushed the 985-combine-multiple-response-projections branch from 1c184f2 to 5a5a30d Compare February 20, 2023 02:09
@kobylynskyi kobylynskyi force-pushed the 985-combine-multiple-response-projections branch from 70d3bbf to 1a5bbd9 Compare February 21, 2023 02:01
@kobylynskyi
Copy link
Owner Author

@jxnu-liguobin
I've made some changes to kotlin/scala .ftls and would appreciate if you take a look at it and possibly make some adjustments too.
Thanks!

jxnu-liguobin
jxnu-liguobin requested changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@jxnu-liguobin jxnu-liguobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, you can try to make changes, or wait for me to make changes sometime in the evening.

@jxnu-liguobin
Copy link
Collaborator

plz see #1032

@kobylynskyi
Copy link
Owner Author

@jxnu-liguobin thank you for your feedback, I've applied your changes to templates in this PR. Please take a look.

jxnu-liguobin
jxnu-liguobin previously approved these changes Feb 22, 2023
View reviewed changes
@kobylynskyi kobylynskyi merged commit e06d69b into develop Feb 22, 2023
@kobylynskyi kobylynskyi deleted the 985-combine-multiple-response-projections branch February 22, 2023 12:16
@kobylynskyi kobylynskyi mentioned this pull request Feb 26, 2023
Merged
kobylynskyi added a commit that referenced this pull request Feb 28, 2023
@kobylynskyi
Ability to combine multiple response projections #985 (#1031)
256b50c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxnu-liguobin jxnu-liguobin jxnu-liguobin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kobylynskyi @jxnu-liguobin