Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save kotlin nullable sign for custom type mapping and apiReturnType #1020

Merged
merged 5 commits into from
Feb 26, 2023
Merged

Save kotlin nullable sign for custom type mapping and apiReturnType #1020

merged 5 commits into from
Feb 26, 2023

Conversation

romash1408
Copy link
Contributor

Description

Related to #1019

Also tests were updated to pass on Windows

Changes were made to:

  • Codegen library - Java
  • Codegen library - Kotlin
  • Codegen library - Scala
  • Maven plugin
  • Gradle plugin
  • SBT plugin

@drubinin
Add test for kobylynskyi#1019
f8f3428
@drubinin
Fix tests to pass on Windows
4165eea 
Tests that used System.lineSeparator() in expectations was failing on Windows because in reality we always generate files with unix line separator
@drubinin
Save kotlin nullable sign for custom type mapping and apiReturnType (k…
6f215d9 
…obylynskyi#1019)
@romash1408
Copy link
Contributor Author

Fixed codestyle errors. Sorry for not doing it before creating PR, I just coudn't start checkstyle locally. It would be nice to specify checkstyle version 8.41 in CONTRIBUTING.md (I tried 10.4 that is default in IDEA, 9.3 and 8.3 - every version throw exception when select graphql-codegen-check-style.xml 😞

@kobylynskyi kobylynskyi merged commit e6465c3 into kobylynskyi:develop Feb 26, 2023
@kobylynskyi
Copy link
Owner

@romash1408 thanks for working on this!

@kobylynskyi kobylynskyi mentioned this pull request Feb 26, 2023
Merged
kobylynskyi added a commit that referenced this pull request Feb 28, 2023
@romash1408 @drubinin @kobylynskyi
Save kotlin nullable sign for custom type mapping and apiReturnType #…
4d57b67 
…1019 (#1020)

---------

Co-authored-by: romash1408 <romash1408@gmail.com>
Co-authored-by: Bogdan Kobylynskyi <92bogdan@gmail.com>
@romash1408 romash1408 deleted the develop branch March 1, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobylynskyi kobylynskyi kobylynskyi approved these changes

@jxnu-liguobin jxnu-liguobin Awaiting requested review from jxnu-liguobin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romash1408 @kobylynskyi @jxnu-liguobin @drubinin