Use input instead of makeEditable for question names #2151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
<input>
(bonus: you can tab-navigate through question names)makeEditable
function to log error if element not foundAlso tried to untangle choices list from
makeEditable
function (as this is the last place that uses this function), but had to many issues to pursue this change.Will make another issue for that, as #554 doesn't cover it.Here: #2152Related issues
Fixes #554