Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade formpack to fix #2057 #2066

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

jnm
Copy link
Member

@jnm jnm commented Nov 7, 2018

Fixes #2057. ⚠️ references a commit from an unmerged PR on formpack: kobotoolbox/formpack#180

This is now running on https://kf.master.kbtdev.org/. To test:

  1. Create a blank form;
  2. Add a "Select One" question;
  3. Drag "Option 2" to the top;
  4. Click the preview icon.

The fix only works for new AssetSnapshots. That means that trying to preview outside the form builder, on a form that has not been saved since deploying this fix, will still fail with argument of type 'int' is not iterable. To clean up the mess, we will need to run this:

AssetSnapshot.objects.filter(xml='', details__contains='''"argument of type 'int' is not iterable"''').delete()

@jnm jnm requested a review from noliveleger November 7, 2018 22:49
@jnm jnm merged commit 3d04616 into master Nov 8, 2018
@jnm jnm deleted the 2057-formpack-preview-fails-with-integer-choice-order branch November 8, 2018 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form preview fails with error argument of type 'int' is not iterable
1 participant