Allows webpack to work with kobo-install when it doesn't run from the host OS.
#2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… settings for webpack dev server
…ack works with local domain names
|
@magicznyleszek, thanks :-) |
jnm
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
kobo-installip address is not used anymore. It only uses a fake domain name which is added to/etc/hosts.I'm running docker in
linuxVM and using the browser frommacOS, sowebpackseeslocalhostas thehostOS, not the virtual machine.This PR allows
webpackto bind all ips on port 3000 (not onlylocalhost) and points the its web server to good IP thanks to the fake domain name.@magicznyleszek :
it should work in
kobo-dockerfrommasterorkobo-installbranches. Do you see any potential issues to do this? Can you test it?@jnm:
I added you too as a reviewer because of a small python change in configuration where RAVEN is not enabled.