Fix XML renderer for snapshots (used when previewing with Enketo) #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pi into 2029-snapshot-xml-renderer
…default XML renderer class, removed AssetSnapshotXFormRenderer
…endMixin.list instead
jnm
reviewed
Oct 23, 2018
kpi/deployment_backends/mixin.py
Outdated
| @@ -145,10 +145,11 @@ def _requests_response_to_django_response(requests_response): | |||
| django_response.write(requests_response.content) | |||
| return django_response | |||
|
|
|||
|
|
|||
| #@renderer_classes((JSONRenderer, XMLRenderer)) | |||
There was a problem hiding this comment.
What's this for? Is it a TODO for the future?
There was a problem hiding this comment.
Yes it was! But I changed my mind since I pushed this commit and I will do it another way
kpi/deployment_backends/mixin.py
Outdated
| def list(self, kpi_request, *args, **kwargs): | ||
| return self.retrieve(kpi_request, None, *args, **kwargs) | ||
|
|
||
| #@renderer_classes((JSONRenderer, XMLRenderer)) |
There was a problem hiding this comment.
Same answer as above :-)
kpi/renderers.py
Outdated
| @@ -49,4 +59,4 @@ class XlsRenderer(renderers.BaseRenderer): | |||
| def render(self, data, media_type=None, renderer_context=None): | |||
| asset = renderer_context['view'].get_object() | |||
| return asset.to_xls_io(versioned=self.versioned, | |||
| kobo_specific_types=self.kobo_specific_types) | |||
| kobo_specific_types=self.kobo_specific_types) | |||
There was a problem hiding this comment.
Our editors love to fight each other about this.
https://www.reddit.com/r/Python/comments/1zjugg/question_why_does_pep8_recommend_leaving_a_blank/
There was a problem hiding this comment.
The problem is not my IDE, it's me. I know about the blank line at the end (and PyCharms too) but sometimes I forget.
I won't anymore.
…a future purpose, but not needed anymore
jnm
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jnm, I finally kept
DEFAULT_RENDERER_CLASSESin settings.I just removed
rest_framework_xml.renderers.XMLRendererand used an extended class of it.This class now replaces
AssetSnapShotRendererwhere it was called. EvenXFormRendereris based on it.Fixes #2029