Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further REST enhancements #2033

Merged
merged 13 commits into from
Dec 10, 2018
Merged

Further REST enhancements #2033

merged 13 commits into from
Dec 10, 2018

Conversation

magicznyleszek
Copy link
Member

@magicznyleszek magicznyleszek commented Oct 17, 2018 •
edited
Loading

Description

  1. bigger link area in services list
  2. another clickable area to display log info modal
  3. display log info modal for pending hooks (if any message is present)
  4. display log tries count (for 2+)
  5. better title for log modal
  6. logs loading pagination (completely missing till now)

Related issues

Part of #2021

jnm
jnm requested changes Dec 7, 2018
View reviewed changes
jsapp/js/actions.es6 Outdated Show resolved Hide resolved
jsapp/js/components/RESTServices/RESTServiceLogs.es6 Show resolved Hide resolved
jsapp/js/components/RESTServices/RESTServiceLogs.es6 Show resolved Hide resolved
@jnm jnm merged commit 87aa7e2 into master Dec 10, 2018
@magicznyleszek magicznyleszek deleted the rest-enhancements-2 branch December 13, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm jnm jnm requested changes

@pmusaraj pmusaraj Awaiting requested review from pmusaraj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magicznyleszek @jnm @noliveleger