Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: endpoint for hash of all assets #1973

Merged
merged 7 commits into from
Sep 6, 2018
Merged

Feature: endpoint for hash of all assets #1973

merged 7 commits into from
Sep 6, 2018

Conversation

noliveleger
Copy link
Contributor

@noliveleger noliveleger commented Aug 29, 2018 •
edited by pmusaraj
Loading

Adds endpoint at assets/hash with hash of all assets, based on version_id. Frontend will consume this endpoint and decide whether to request a refresh of the asset list or not.

Fixes #1894.

@noliveleger noliveleger requested a review from pmusaraj August 29, 2018 14:59
@jnm jnm added the coded label Aug 29, 2018
@jnm jnm removed the coded label Aug 29, 2018
@noliveleger noliveleger reopened this Aug 29, 2018
@jnm jnm added the coded label Aug 29, 2018
@noliveleger noliveleger requested a review from jnm August 29, 2018 20:34
@noliveleger
Copy link
Contributor Author

@pmusaraj, I think you can review it. Otherwise @jnm may take a look at it.

pmusaraj
pmusaraj approved these changes Aug 30, 2018
View reviewed changes
Copy link
Contributor

@pmusaraj pmusaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pmusaraj pmusaraj changed the title Added new endpoint for hash of all assets Feature: endpoint for hash of all assets Aug 30, 2018
@pmusaraj pmusaraj mentioned this pull request Aug 30, 2018
Merged
@pmusaraj pmusaraj merged commit 65c5107 into master Sep 6, 2018
@jnm jnm removed the coded label Sep 6, 2018
@pmusaraj pmusaraj deleted the issue-1894 branch September 6, 2018 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmusaraj pmusaraj pmusaraj approved these changes

@jnm jnm Awaiting requested review from jnm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noliveleger @pmusaraj @jnm