Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header name fixes #1938

Merged
merged 12 commits into from
Sep 17, 2018
Merged

Header name fixes #1938

merged 12 commits into from
Sep 17, 2018

Conversation

magicznyleszek
Copy link
Member

@magicznyleszek magicznyleszek commented Aug 16, 2018 •
edited
Loading

Description

Too many places where you can change the name of the form are confusing.

Things in this PR:

  • header form name is no longer an editable input
  • long form names are displayed in smaller font to fit them
  • 🐛 don't show old asset name while loading new one (especially visible when going from form to list view and to other form) - now there is a spinner while loading the asset
  • 🐛 fixed asset row long text ellipsis-trimming (title, description and dates)
  • some cleanups and dead code removals
  • immediate title update with ENTER key

Related issues

Fixes #1883
Closes #1756

@magicznyleszek
remove header name editing, add some improvements
4b2e336 
make header title non-editable, handle really long names better, don't show old asset name while loading new one, remove unused imports and dead code
@magicznyleszek
fix asset row long text trimming
bfb6ebf 
plus tidy up vertical size
@magicznyleszek magicznyleszek requested review from pmusaraj and jnm August 16, 2018 06:56
@magicznyleszek
Copy link
Member Author

magicznyleszek commented Aug 30, 2018 •
edited
Loading

Note: undo editing header changes, keep bugfixes, maybe no spinner

@magicznyleszek magicznyleszek changed the title Remove form name editing from header Header name fixes Sep 11, 2018
@magicznyleszek
Copy link
Member Author

magicznyleszek commented Sep 11, 2018 •
edited
Loading

@pmusaraj I undid unwanted changes and added ENTER key handling

@pmusaraj pmusaraj merged commit 6156c6c into master Sep 17, 2018
@pmusaraj pmusaraj deleted the issue-1883 branch September 17, 2018 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmusaraj pmusaraj Awaiting requested review from pmusaraj

@jnm jnm Awaiting requested review from jnm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove form name editing in app header Enter key and Edit Name/Description
2 participants
@magicznyleszek @pmusaraj