Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got an error on new group variants in tailwind plugin #101

Closed
ceopaludetto opened this issue Feb 1, 2023 · 1 comment · Fixed by #103
Closed

Got an error on new group variants in tailwind plugin #101

ceopaludetto opened this issue Feb 1, 2023 · 1 comment · Fixed by #103

Comments

@ceopaludetto
Copy link

Describe the bug
The implementation of group and peer variants are incorrect, making postcss crash

To Reproduce

  1. Intall @kobalte/tailwindcss
  2. Try to use any group or peer variant
  3. Get this error:
Stack trace Error: Expected a pseudo-class or pseudo-element. at Root._error (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/parser.js:174:16) at Root.error (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/selectors/root.js:43:19) at Parser.error (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/parser.js:740:21) at Parser.expected (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/parser.js:1133:19) at Parser.pseudo (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/parser.js:895:19) at Parser.parse (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/parser.js:1084:14) at Parser.loop (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/parser.js:1043:12) at new Parser (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/parser.js:164:10) at Processor._root (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/processor.js:53:18) at Processor._runSync (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/processor.js:100:21)

Expected behavior
Group and peer variants should work

Additional context
I think group and peer variants have an unnecessary : in declaration. Should be :merge(.group)[data-${state}] &

https://github.com/fabien-ml/kobalte/blob/17db58a85daa8cc8508df3317d7e8e6fe0944079/packages/tailwindcss/src/index.js#L35

fabien-ml added a commit that referenced this issue Feb 1, 2023
@fabien-ml
Copy link
Collaborator

fixed in v0.4.1 of the tailwind plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants