pre-commit hooks with ruff added #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koaning
approved these changes
May 6, 2024
|
LGTM. Thanks! |
|
I am aware that the code checks are error-ing btw, but it feels fine to merge since those errors feel unrelated. |
|
That's btw the same error I encountered previously, FAILED tests/test_text.py::test_basic_bpemb[max] , but the first time it disappeared after a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering if I should add embetter and tests in args: [--fix], similar to what's happening in sklego. I also let the ruff go over the jupyter notebooks, even though I saw it wasn't specified in the sklego pre-commit looks.