-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions option breaks if local path contains a dot anywhere #79
Comments
Isn't it fixed with #92 ? |
yes :) |
I don't think this regex works on windows machines, since the directory separators are backslashes I believe the tests are failing on my windows machine, because of this. We can probably fix it by using basename: !/\./.exec(basename(path)) |
@adenflorian I believe your fix reintroduced the bug if the basename contains a dot anywhere. I'm currently running into this issue. I tried switching to @Necromos's regex pattern, but it still fails. To be honest, I don't fully understand why this regex exists in the first place. Is it to prevent searching for ".html.html" ? Can we re-open this bug? Max |
The regex in this line will match paths with a dot anywhere. In particular if I'm developing in the local folder
/home/razorx/web/example.com
and try to use theextensions
option to serve/foo
thenpath = /home/razorx/web/example.com/foo
and will match the regex thus skipping the if block.The text was updated successfully, but these errors were encountered: