Clean up defmt-semihosting. #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed the static mut * Switched to the semihosting crate, for Cortex-R support
Deploying knurling-defmt-book with
|
| Latest commit: |
9f6aae5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://aa23ca1f.knurling-defmt-book.pages.dev |
| Branch Preview URL: | https://semihosting-updates.knurling-defmt-book.pages.dev |
|
cc @driveraid |
Urhengulas
approved these changes
Mar 7, 2025
| // safety: Must be paired with corresponding call to release(), see below | ||
| let restore = unsafe { critical_section::acquire() }; | ||
|
|
||
| if TAKEN.load(Ordering::Relaxed) { | ||
| // NB: You can re-enter critical sections but we need to make sure |
There was a problem hiding this comment.
What does NB stand for? non-blocking?
|
|
||
| // safety: accessing the `static mut` is OK because we have acquired a critical section. | ||
| unsafe { CS_RESTORE = restore }; | ||
| unsafe impl Sync for SemihostingEncoder {} |
There was a problem hiding this comment.
Why does SemihostingEncoder need to be marked as Sync?
There was a problem hiding this comment.
Because it's used in a static variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #942