Refactor CustomTranslationsLoader for Compatibility with Statamic #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a compatibility issue with Statamic. The
CustomTranslationsLoaderclass was previously usingFileLoader, which led to conflicts as Statamic also mutates the loader.To resolve this, we've refactored
CustomTranslationsLoaderto useLoaderContractinstead ofFileLoader. This change enhances flexibility and ensures compatibility with Statamic and potentially other packages that mutate the loader.Key Changes:
defaultLoaderproperty type is nowLoaderContract.LoaderContractinstead ofFileLoader.This change is crucial for ensuring our package's seamless integration with Statamic. Please review and provide feedback.