Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for nested arrays as query parameters for bash examples #605

Conversation

eschricker
Copy link
Contributor

Fixed: When using nested arrays as query parameters, the bash examples throw an exception.

Example: filter[category][]=2&filter[category][ ]=6 broke the existing code.

Solution: Check if the parameter is an array and handle it accordingly.

@shalvah
Copy link
Contributor

shalvah commented Jan 19, 2023

Can you add a test? You can follow the examples in #603

@eschricker
Copy link
Contributor Author

I restructured the code to support multiple nested arrays, as in the code for js, python and php.

In addition, I have extended the referenced test.

@shalvah shalvah merged commit 23810a8 into knuckleswtf:master Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants