Add Elements theme #559
Merged
Add Elements theme #559
+14,947
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new theme (finally 🎉 ). The theme is based on the Stoplight Elements look, so is named
elements. Of course, it isn't exactly the same. There are stylistic differences, some things are removed to reduce complexity, and ours is a scrollable single page.Also, this work led to a few improvements on the default theme, and I'll be going back to add even more soon
There's probably still a lot missing. Officially, this is still "beta". At the very least, I need to refactor and extract the duplicated code between both themes' Try It Out implementation to a common base.
I had to "reinvent" some of the Scribe components, because they were written with a specific theme in mind. In the next major, we'll probably move these into the respective theme folders.
The
linksproperty of$metadatasent to the view was also deprecated and will be removed in the next major.