Fix validation rule accepted

[hishpeck]

When using accepted or accepted_if validation rules on a field, the generated body parameters documentation hints that the value is an optional string. This is not true, as you can see in the Laravel Validation documentation: https://laravel.com/docs/9.x/validation#rule-accepted

This PR aims to change the type, description and requirement of fields with those rules.

Documentation and example request generated before the changes:

Documentation and example request generated after the changes:

[shalvah]

This is good, but doesn't the documentation say it can be "yes" or 1? I don't think we can conclusively assign a boolean type.

[hishpeck]

Yes, you are right if we think in terms of strict typing. I wanted it to be consistent with the boolean validation rule, which can be true, false as well as 1, 0, "1" and "0" (but I see there's no "yes" and "no" option). It is still considered a boolean type in Scribe.

If we leave the type empty, it will default to string type, which I don't think makes much sense either, and from what I can see, displaying multiple available types would be pretty hacky.

[shalvah]

Right. And it's an API after all. Not very likely we'll have a "yes" sent in.

[hishpeck]

@shalvah I'm sorry, can you provide guidance on issues that popped up here?

I noticed that lint errors appeared before I started implementing thi PR. I can fix the issue about Model::first() being undefined (but I think it's outside of this PR's scope), but I don't really know how to fix the Filesystem errors, as I believe they are caused by code supporting versions 1 and 2, and I'm not really sure how to fix it other than adding // @phpstan-ignore-line.

[shalvah]

Just ignore any lint errors that aren't from your code.

[shalvah]

@Hiszpek can you fix the tests?

[hishpeck]

@shalvah The reason the tests on 7.4 fail is because it contains Laravel 6.20, but the accepted_if rule has been implemented somewhere around version 8. I couldn't find any information in contribution guide on how to handle situations like this, should I just scrap the accepted_if part and only leave the accepted rule?

Sorry for leaving this hanging for a while.

[shalvah]

https://github.com/knuckleswtf/scribe/search?q=marktestskipped

[shalvah]

Seems like there's already an example for what to do in that file:

scribe/tests/Unit/ValidationRuleParsingTest.php

Lines 323 to 329 in 04ac914

	if (version_compare(Application::VERSION, '7.0.0', '>=')) {
	yield 'different' => [
	['different_param' => 'string|different:other_field'],
	[],
	['description' => "The value and <code>other_field</code> must be different."],
	];
	}