Correct BelongsTo relation creation #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 26, 2022 21:36
…sage and exception dumps, when creating (storing) failed
…g BelongsTo relationship correctly
…nfigs after test is complete
|
@shalvah this test case needs to create :inmemory: db with migrations, so it failes. So here I'm stuck |
|
Some nested data loading (in factory configuring) is workaround about #321 problem, so we can fix it clearly with real call of |
|
Hmm, I'll take a look at this and see what I can do. |
|
Well done! I see you've put in a lot of work on the tests, but your change seems pretty innocuous, so I think we can live without the tests. |
1 task
|
@shalvah You did not delete the |
|
Deleted it on master.
…On Sun, Jan 30, 2022, 16:37 Georgy Torquemada ***@***.***> wrote:
@shalvah <https://github.com/shalvah> You did not delete the
afterTestCleanup function in tests, now it unused
—
Reply to this email directly, view it on GitHub
<#417 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADNSD4OMMV672RASPOYMHVDUYVLNDANCNFSM5M3ZRTFQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
If we add more features that rely on the database, we may eventually add these database tests back, and your work might come in handy. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #415
Closes: #412