ADDED - search id in DB when model instance #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really understand what's going on here. You have to provide a test case that describes what this is doing. If you don't know how to add a test to the project, you can at least post some example code here. |
|
Yes sorry for the lack of information. When no example comment is specified, Scribe takes a randomly generated id which can cause a "ModelNotFoundException". My modification allows to select the 1st id in database if it exists instead of taking a randomly generated id |
shalvah
reviewed
Jan 24, 2022
|
Thanks, Sorry I forgot =/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR allows you to search for an existing ID in DB rather than using when no example.
Regards