Fix bug where toggling the menu on mobile would jump to the top of the page

[robbieaverill]

No description provided.

[shalvah]

Not sure what this does exactly, but hope it works🤣

[robbieaverill]

Hey @shalvah, what it's doing is preventing the default behaviour when you click on the "menu" button on mobile views. The button is an anchor, so the default behaviour is to follow the href attribute, which is #. What you saw before this patch is that clicking on the menu button on mobile would open the menu, and jump to the top of the page. It now only opens the menu.

[shalvah]

Ah, thanks.

…

On Wed, Jan 5, 2022, 01:49 Robbie Averill ***@***.***> wrote: Hey @shalvah <https://github.com/shalvah>, what it's doing is preventing the default behaviour when you click on the "menu" button on mobile views. The button is an anchor, so the default behaviour is to follow the href attribute, which is #. What you saw before this patch is that clicking on the menu button on mobile would open the menu, and jump to the top of the page. It now only opens the menu. — Reply to this email directly, view it on GitHub <#400 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADNSD4NKBPTUBKVHYUP6DSTUUOIRPANCNFSM5K46HRKA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>